[Bug 2221418] Review Request: python-tensile - Tool for creating benchmark-driven backend libraries for GEMMs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2221418

Jeremy Newton <alexjnewt@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #10 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> ---
Ok so for reference, the review checklist is here:
https://download.copr.fedorainfracloud.org/results/mystro256/playground/fedora-rawhide-x86_64/06880168-python-tensile/fedora-review/review.txt

I looked through it and I think the only outstanding issue is:
>      Note: Directories without known owners: /usr/share/cmake
This is because the package MUST require on cmake-filesystem to avoid causing
the directory becoming orphaned after uninstall.
So please add "Requires: cmake-filesystem" (sorry I'm a stickler for correct
filesystem ownership)

As well to be clear, you've already confirmed that files in
/usr/lib/python3.12/site-packages/Tensile/Source/ are not devel files.

With that I'll add my approval, but please don't forget the extra
cmake-filesystem requires.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2221418

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202221418%23c10
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux