[Bug 2257474] Review Request: rust-parse_datetime - Parsing human-readable time strings and converting them to a DateTime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2257474

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx
                 CC|                            |decathorpe@xxxxxxxxx
             Status|NEW                         |ASSIGNED
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?



--- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I got a bunch of test failures building this package locally:

from --lib tests:

```
---- parse_relative_time::tests::test_days stdout ----
thread 'parse_relative_time::tests::test_days' panicked at
src/parse_relative_time.rs:244:9:
assertion `left == right` failed
  left: Duration { secs: 0, nanos: 0 }
 right: Duration { secs: 86400, nanos: 0 }
---- parse_relative_time::tests::test_direction stdout ----
thread 'parse_relative_time::tests::test_direction' panicked at
src/parse_relative_time.rs:401:9:
assertion `left == right` failed
  left: Duration { secs: -90000, nanos: 0 }
 right: Duration { secs: -3600, nanos: 0 }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- parse_relative_time::tests::test_fortnights stdout ----
thread 'parse_relative_time::tests::test_fortnights' panicked at
src/parse_relative_time.rs:200:9:
assertion `left == right` failed
  left: Duration { secs: 1123200, nanos: 0 }
 right: Duration { secs: 1209600, nanos: 0 }
---- parse_relative_time::tests::test_duration_parsing stdout ----
thread 'parse_relative_time::tests::test_duration_parsing' panicked at
src/parse_relative_time.rs:418:9:
assertion `left == right` failed
  left: Duration { secs: 31449600, nanos: 0 }
 right: Duration { secs: 31536000, nanos: 0 }
---- parse_relative_time::tests::test_hours stdout ----
thread 'parse_relative_time::tests::test_hours' panicked at
src/parse_relative_time.rs:264:9:
assertion `left == right` failed
  left: Duration { secs: -82800, nanos: 0 }
 right: Duration { secs: 3600, nanos: 0 }
failures:
    parse_relative_time::tests::test_days
    parse_relative_time::tests::test_direction
    parse_relative_time::tests::test_duration_parsing
    parse_relative_time::tests::test_fortnights
    parse_relative_time::tests::test_hours
```

from --doc tests:

```
---- src/lib.rs - parse_datetime_at_date (line 113) stdout ----
Test executable failed (exit status: 101).
stderr:
thread 'main' panicked at src/lib.rs:11:2:
assertion `left == right` failed
  left: 2024-01-12T23:20:45.998325252
 right: 2024-01-11T23:20:45.998325252
stack backtrace:
   0:     0x55b782ddb8fc -
<std::sys_common::backtrace::_print::DisplayBacktrace as
core::fmt::Display>::fmt::h27ca87202d5ecd83
   1:     0x55b782dfcbd0 - core::fmt::write::h09cee20e85f5b605
   2:     0x55b782dd9b1d - std::io::Write::write_fmt::h8a4619fb34e615dd
   3:     0x55b782ddb6e4 - std::sys_common::backtrace::print::hf82af90349e2f7c0
   4:     0x55b782ddcc47 -
std::panicking::default_hook::{{closure}}::h47113dde962f99f7
   5:     0x55b782ddc9af - std::panicking::default_hook::h6f77232024947fdb
   6:     0x55b782ddd0c8 -
std::panicking::rust_panic_with_hook::h99c637896ca8c931
   7:     0x55b782ddcfae -
std::panicking::begin_panic_handler::{{closure}}::had839c9cabb1c34e
   8:     0x55b782ddbdc6 -
std::sys_common::backtrace::__rust_end_short_backtrace::h7f65a9354cd915f2
   9:     0x55b782ddcd12 - rust_begin_unwind
  10:     0x55b782ce3cf5 - core::panicking::panic_fmt::h6af3f6c496ab9237
  11:     0x55b782ce401b -
core::panicking::assert_failed_inner::h29a649f352d26462
  12:     0x55b782ce79aa - core::panicking::assert_failed::h4aa2d7d47e97c7d4
  13:     0x55b782cf05fa -
rust_out::main::_doctest_main_src_lib_rs_113_0::h22170e33ee46132b
  14:     0x55b782cf0456 - rust_out::main::ha9f16ac99a021700
  15:     0x55b782ce6883 -
core::ops::function::FnOnce::call_once::hc5731df068f454ea
  16:     0x55b782ce5e36 -
std::sys_common::backtrace::__rust_begin_short_backtrace::h5ff7553019ede203
  17:     0x55b782ce5e89 - std::rt::lang_start::{{closure}}::h3715748a181cec2d
  18:     0x55b782dd6c17 - std::rt::lang_start_internal::h4ca6f69a96534026
  19:     0x55b782ce5e67 - std::rt::lang_start::h291929258001f237
  20:     0x55b782cf0655 - main
  21:     0x7f567f0b314a - __libc_start_call_main
  22:     0x7f567f0b320b - __libc_start_main@@GLIBC_2.34
  23:     0x55b782ce4455 - _start
  24:                0x0 - <unknown>
failures:
    src/lib.rs - parse_datetime_at_date (line 113)
```

Not sure why the COPR build passed but mine failed ... is it related to the
current time? I ran the tests just after midnight local time.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2257474

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257474%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux