Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trac-monotone-plugin - Monotone version control plugin for Trac https://bugzilla.redhat.com/show_bug.cgi?id=428549 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-16 22:03 EST ------- Builds fine; rpmlint says: trac-monotone-plugin.noarch: W: no-version-in-last-changelog and indeed, the changelog entry doesn't have a version. http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs has info on changelog entry formats. Since that's the only issue I can find with this package, I'll go ahead and approve it and you can fix it when you check in. Checklist: * source files match upstream (I followed the instructions in the spec and diffed against the contents of the tarball.) * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X rpmlint has one valid complaint. * final provides and requires are sane: trac-monotone-plugin = 0.0.12-1.20080116mtn3907adc7.fc9 = monotone >= 0.31 python(abi) = 2.5 python-setuptools trac * %check is not present; no test suite upstream. I don't have a trac instance I can use to test this. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED; please fix the changelog entry when checking in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review