[Bug 2253359] Review Request: zstr - A C++ header-only ZLib wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2253359

Gwyn Ciesla <gwync@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Gwyn Ciesla <gwync@xxxxxxxxxxxxxx> ---
rpmlint is clean
naming is OK
meets packaging guidelines
License related items are all OK
Spec is legible, in American English
Source hashes match
Builds locally and in mock on x86_64, BuildRequires are sound.
No locales.
Nothing bundled
Not relocatable
Ownership is good.
No duplicates.
Permissions are good.
Macro usage is good.
Contains permissable code.
Docs handled approprately.
No static libraries.
-devel only package.
No .la
No GUI apps
No cross-ownership.
All ASCII filenames.
No requirement of deprecated packages.

Looks great to me!
APPROVED


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2253359

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253359%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux