[Bug 2246133] Re-Review Request: remind - A sophisticated calendar and alarm program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2246133



--- Comment #22 from Neil Hanlon <neil@xxxxxxxx> ---
Update incoming.


a) Can some of the tests be run? See for example:
https://git.skoll.ca/Skollsoft-Public/Remind/src/branch/master/tests/test-for-backends.rem

Yep - all except one of the test sets complete. Namely, it is the 'convert from
localtime to utc' ones which appear to act incorrectly. I suspect that this is
due to changes in how timezones are handled in Fedora, but I'm not entirely
sure. For the meantime, I've disabled this test.

```
Remind:  Acceptance test FAILED
Examine the file test.out to see where it differs from the
reference file test.cmp.  Here are the first 200 lines of
diff -u test.out test.cmp
--- ../tests/test.out   2024-01-09 19:22:22.912648481 +0000
+++ ../tests/test.cmp   2023-12-14 21:08:46.000000000 +0000
@@ -11513,117 +11513,117 @@
 # Test conversion between local time and UTC

 set a localtoutc('2022-01-01@12:00')
-localtoutc(2022-01-01@12:00) => 2022-01-01@12:00
+localtoutc(2022-01-01@12:00) => 2022-01-01@17:00
 set a localtoutc('2022-03-13@03:59')
-localtoutc(2022-03-13@03:59) => 2022-03-13@03:59
+localtoutc(2022-03-13@03:59) => 2022-03-13@07:59
 set a localtoutc('2022-03-13@04:00')
-localtoutc(2022-03-13@04:00) => 2022-03-13@04:00
+localtoutc(2022-03-13@04:00) => 2022-03-13@08:00
 set a localtoutc('2022-03-13@04:01')
-localtoutc(2022-03-13@04:01) => 2022-03-13@04:01
+localtoutc(2022-03-13@04:01) => 2022-03-13@08:01
 set a localtoutc('2022-06-01@12:00')
-localtoutc(2022-06-01@12:00) => 2022-06-01@12:00
+localtoutc(2022-06-01@12:00) => 2022-06-01@16:00
 set a localtoutc('2022-11-06@02:59')
-localtoutc(2022-11-06@02:59) => 2022-11-06@02:59
+localtoutc(2022-11-06@02:59) => 2022-11-06@07:59
 set a localtoutc('2022-11-06@03:00')
-localtoutc(2022-11-06@03:00) => 2022-11-06@03:00
+localtoutc(2022-11-06@03:00) => 2022-11-06@08:00
 set a localtoutc('2022-11-06@03:01')
-localtoutc(2022-11-06@03:01) => 2022-11-06@03:01
+localtoutc(2022-11-06@03:01) => 2022-11-06@08:01
 set a localtoutc('2022-12-01@12:00')
-localtoutc(2022-12-01@12:00) => 2022-12-01@12:00
+localtoutc(2022-12-01@12:00) => 2022-12-01@17:00
```


b) Could the documentation in the tools subpackage be split into a noarch
documentation only subpackage?

Certainly. Done.

c) Seems to be an issue when building on i686:
https://koji.fedoraproject.org/koji/taskinfo?taskID=111534141

This one is new to me--i'm not really sure what the solution is

d) Do let upstream know about the incorrect FSF address

I have started an email conversation with upstream about this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2246133

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246133%23c22
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux