https://bugzilla.redhat.com/show_bug.cgi?id=2254883 --- Comment #8 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- This mostly looks fine, except... upstream does not ship the license file in the crate (sorry for not catching that earlier!). This is a common issue where upstream has one repo hosting multiple crates, I suggest the following: - send one PR to https://github.com/printfn/fend symlinking the license file and any other relevant files to the individual crate directories. I normally use `cargo package --allow-dirty --no-verify` followed by `tar tf .. | grep LICENSE` to demonstrate the license files get picked up - put the PR as a comment above a new Source: https://raw.githubusercontent.com/printfn/fend/main/LICENSE.md line - in %prep, `cp -p %{SOURCE1} .` to copy in the license file - in %files devel, replace #FIXME with %license %{crate_instdir}/LICENSE.md -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254883 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254883%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue