https://bugzilla.redhat.com/show_bug.cgi?id=2257189 --- Comment #4 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > (In reply to Michel Lind from comment #2) > > (In reply to Fabio Valentini from comment #1) > > > Three minor issues: > > > > > > - Please document the patch (like adding a line above "Patch: ..." with "# > > > bump serial_test dev-dependency from 0.5 to 2" > > > > it has this right now > > # * bump serial_test to 2 > > > > I can make it more explicit > > Ah, that line is only in the linked spec, but not in the spec in the linked > SRPM. > So I guess you forgot to re-run rpmbuild -bs after adding it. > The line you have there is fine, no need to be more verbose. > > > > - Can you submit the patch to update this dependency as a PR to upstream? > > > > Can do. In this case I should probably make upstream accept a range from 0.5 > > to 2, right, since obviously it still works with 0.5 too > > That would be perfect. Something like ">=0.5,<3". > > > > - Please exclude some files that don't make sense in the packaging - like > > > coverage.sh and coverage-style.css.patch. This might also make sense as a PR > > > for upstream. > > > > > > > Will do too, thanks > > :+1: sent PRs upstream for both (see updated spec for links to PRs) Spec URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton.spec SRPM URL: https://salimma.fedorapeople.org/rust-reference-counted-singleton-0.1.2-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257189 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257189%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
