https://bugzilla.redhat.com/show_bug.cgi?id=2251086 --- Comment #28 from Tom Rix <trix@xxxxxxxxxx> --- (In reply to Benson Muite from comment #26) > For the CMake configuration, may want to add: > -DFETCH_CONTENT_FULLY_DISCONNECTED=ON \ > -DFETCH_CONTENT_QUEIT=ON \ > -DROCFFT_BUILD_OFFLINE_TUNER=ON \ > -DBUILD_CLIENTS_BENCH=ON \ > -DBUILD_CLIENTS_SAMPLES=ON > > To run tests probably: > https://github.com/ROCm-Developer-Tools/HIP-CPU > needs to be packaged. There are no releases for this project, it is self described as "Please note the library is being actively developed, and is known to be incomplet; it might also be incorrekt and there could be a few bad bugs lurking" If we are to depend on something to check the other packages, it needs to be stable and aligned with the other rocm packages. Otherwise we will spend a lot of time chasing false problems. So I would rather we did not package it. Testing depends on a gpu. The testing I have set in the other rocm packages is to build an optional -test subpackage so the tests can be installed to a machine that has a gpu. My preference is for rocFFT to do similar. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251086%23c28 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
