https://bugzilla.redhat.com/show_bug.cgi?id=2254922 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx CC| |jplesnik@xxxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok TODO: Based on rpmlint, consider to use Summary text also for Description URL and Source0 FIX: Please switch URL and Source0 from search.cpan.org to metacpan.org https://metacpan.org/dist/Protocol-SOCKS https://cpan.metacpan.org/authors/id/T/TE/TEAM/Protocol-SOCKS-%{version}.tar.gz All tests passed BuildRequires FIX: Add build-require coreutils - it is needed for %{_fixperms} perl(constant) - lib/Protocol/SOCKS/Constants.pm:25 perl(Exporter) - lib/Protocol/SOCKS/Constants.pm:6 perl(strict) - Makefile.PL:3 perl(warnings) - Makefile.PL:4 $ rpm -qp --requires perl-Protocol-SOCKS-0.003-1.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(constant) 1 perl(Exporter) 1 perl(Future) 1 perl-libs 1 perl(parent) 1 perl(Protocol::SOCKS) 1 perl(Protocol::SOCKS::Constants) 1 perl(Socket) 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Protocol-SOCKS-0.003-1.fc40.noarch.rpm | sort | uniq -c 1 perl(Protocol::SOCKS) = 0.003 1 perl-Protocol-SOCKS = 0.003-1.fc40 1 perl(Protocol::SOCKS::Client) = 0.003 1 perl(Protocol::SOCKS::Constants) = 0.003 1 perl(Protocol::SOCKS::Server) = 0.003 Binary provides are Ok. $ rpmlint ./perl-Protocol-SOCKS* ================================ rpmlint session starts ========================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 perl-Protocol-SOCKS.noarch: W: description-shorter-than-summary perl-Protocol-SOCKS.src: W: description-shorter-than-summary == 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.2 s == Rpmlint is ok TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. TODO: Use new %make_* macros and remove packlist by ExtUtils::MakeMaker's variable. 1) Add NO_PERLLOCAL=1 NO_PACKLIST=1 to command perl Makefile.PL and remove find %{buildroot} -type f -name .packlist -exec rm -f {} ';' 2) Replace make %{?_smp_mflags} by %{make_build} 3) Replace make pure_install PERL_INSTALL_ROOT=%{buildroot} by %{make_install} 4) Add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254922 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254922%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
