[Bug 2256310] Review Request: golang-github-bep-mclib - A simple library to make it possible to run Mkcert's main method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2256310

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mikel@xxxxxxxxxxxxxxx



--- Comment #3 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
> %build
> for cmd in gen; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done
> 
> %install
> %gopkginstall
> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
> (...)
> %files
> %license LICENSE
> %doc README.md gen/truststore_other.go.txt
> %{_bindir}/*

The binary in gen is a testing tool not required to be present in the system to
build Hugo (correct me if I'm wrong). Thus, it's better only to install the
library.

You'll need to add "%global debug_package %{nil}" once removed the binary part.

I would also recommend to delete the `gen` dir in %prep, as it add some
dependencies that are not required if the binary is not built.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2256310

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256310%23c3
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux