[Bug 2256975] Review Request: rust-libdeflater - Bindings to libdeflate for DEFLATE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2256975



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Thank you for the review!

(In reply to Fabio Valentini from comment #2)
> Please make sure to exclude the scripts/ folder from the installed files in
> some way (either by patching Cargo.toml to add an `exclude = ["/scripts"]`
> setting under the `[package]` table, or by using `%exclude
> %{crate_instdir}/scripts` in the %files list of the -devel subpackage).
> Otherwise the package gets an unwanted dependency on /usr/bin/ruby.

Great catch! I [added this to the unretirement
PR](https://src.fedoraproject.org/fork/music/rpms/rust-libdeflater/c/edffdceefdf30f3662f3f12fa1d4a263c10154c1)
and confirmed that this removed the packaged scripts/ directory and the
unwanted /usr/bin/ruby dependency.

Releng ticket for unretirement filed: https://pagure.io/releng/issue/11874


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2256975

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256975%23c3
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux