https://bugzilla.redhat.com/show_bug.cgi?id=2256974 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #2) > Some non-blocking comments / feedback: > > - Thank you for working to link with system libdeflate instead of the > bundled copy! > I assume that you wanted to replace <LINK> with a link to an upstream PR? Thanks! I thought I updated that, but it looks like I only fixed the PR[1] and not the .src.rpm I provided for review. > - When re-importing the package after the unretirement, please take care > wrt/ changelog. Sometimes un-retirements of packages that use rpmautospec > result in weird and / or a lot of missing changelog entries. Good point. I’ll check the changelogs and use a changelog file to override the history if needed. > - You can commit a rust2rpm.toml config file into dist-git to preserve the > libdeflate-devel dependency: > > ``` > [requires] > build = ["pkgconfig(libdeflate)"] > lib = ["pkgconfig(libdeflate)"] > ``` Thanks. That matches what I have in the PR[2]. [1] https://src.fedoraproject.org/rpms/rust-libdeflate-sys/pull-request/1#_7__20 [2] https://src.fedoraproject.org/rpms/rust-libdeflate-sys/pull-request/1#_8__2 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256974 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256974%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
