https://bugzilla.redhat.com/show_bug.cgi?id=2249863 --- Comment #11 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #9) > Thank you for submitting your patches to upstream! Package looks good to me. Thank you for the review! > Two tips / hints for the future: > > 1. Please use "rust2rpm -p" for applying changes to Cargo.toml. > Changes to Cargo.toml can affect the spec file that is generated by > rust2rpm, so these changes need to happen at a stage where the changes *can* > affect spec generation (which is what "rust2rpm -p" is for). https://src.fedoraproject.org/rpms/rust-lz4-sys/c/5f039fcda47c52f3234a889e3260aa555664b3ba?branch=rawhide > 2. You can store a rust2rpm.toml config file in dist-git to preserve some > changes for future updates: > […] https://src.fedoraproject.org/rpms/rust-lz4-sys/c/a31c09bee84d3c32c0115a3125def01d22294a95?branch=rawhide > Recommended post-import rust-sig tasks: > > - set up package on release-monitoring.org: Done, https://release-monitoring.org/project/370756/ > - add @rust-sig with "commit" access as package co-maintainer > (should happen automatically) Done, hadn’t happened automatically (yet?) > - set bugzilla assignee overrides to @rust-sig (optional) Not planned > - track package in koschei for all built branches > (should happen automatically once rust-sig is co-maintainer) Done -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249863 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249863%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
