https://bugzilla.redhat.com/show_bug.cgi?id=2256758 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Petr Menšík <pemensik@xxxxxxxxxx> --- I would suggest using %autosetup instead of %setup. Also I would recommend to reuse %{url} in Source0 to reduce repetition. URL: https://heasarc.gsfc.nasa.gov/docs/software/ftools/fitsverify/ Source0: %{url}/%{name}-%{version}.tar.gz I haven't seen a package with C code without at least Makefile, but it seems it does everything required. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2256758 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256758%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue