https://bugzilla.redhat.com/show_bug.cgi?id=2254882 --- Comment #2 from Lumír Balhar <lbalhar@xxxxxxxxxx> --- There is only one thing blocking the approval now - tests. The sources contain them so why not run them? First, the project does not use tox so you should change this line: %pyproject_buildrequires -t to %pyproject_buildrequires requirements.txt There are better ways but the dependency on pytest is not declared anywhere else in the project so this is what we have. Then, it's not possible to run the tests from the build folder because it adds sources of murmurhash module into the PYTHONPATH but the tests directory is installed together with the rest of the files, so we can actually run them from buildroot. That requires disabling caching for pytest so we don't have to remove .pytest-cache folder later: %check pushd %{buildroot}/%{python3_sitearch} %pytest -p no:cacheprovider %{pypi_name}/tests popd If you don't want to ship the tests, which I think you don't, you can remove them here before you popd from the installation destination. One non-blocking comment: I'm not a big fan of %{pypi_version}. Why not just put the version into `Version: ` and then use %{version}? You already use %{version} in Source0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2254882 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254882%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
