https://bugzilla.redhat.com/show_bug.cgi?id=2256466 Steve Cossette <farchord@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |farchord@xxxxxxxxx --- Comment #4 from Steve Cossette <farchord@xxxxxxxxx> --- 1- Remove all build requirements except for python3-devel and kf6-filesystem (kf6-rpm-macros is included in that, thus not needed here either) 2- Add the following build requirements, used for the import test: # Test dependencies: BuildRequires: python3dist(pytest) BuildRequires: python3dist(gv) 3- Add the following right after the %prep section, per https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/: %generate_buildrequires %pyproject_buildrequires 4- %build section should only contain: %pyproject_wheel 5- %install section should only contain the following: %pyproject_install %pyproject_save_files kapidox 6- Some tests should be added in %check. Seems the meager test(s) in this package dont really work with %tox or %pytest, and the test script itself don't run with python. So we basically can only do an import test. Add a %check section, and add this in it: %pyproject_check_import 7- Change %files to: %files -f %{pyproject_files} 8- Remove the following from %files: %{python3_sitelib}/kapidox %{python3_sitelib}/kapidox-%{version}-py*.egg-info 9- Change licensing to SPDX: BSD-2-Clause AND CC0-1.0 AND LGPL-3.0-or-later That should do it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2256466 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202256466%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
