https://bugzilla.redhat.com/show_bug.cgi?id=2251524 --- Comment #4 from Beck Liu <shattuckite@xxxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/shattuckite/review/fedora-rawhide-x86_64/06844262-libformfactor/libformfactor.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/shattuckite/review/fedora-rawhide-x86_64/06844262-libformfactor/libformfactor-0.3.1-1.fc40.src.rpm Thanks for you reviewing. Hope I fixed the all as you suggested. > -DCMAKE_BUILD_TYPE=Release > Should be RelWithDebInfo I see that the RelWithDebInfo should be comparably efficient with Release, but get debug symbols. [1] Is this your reason that I should use RelWithDebInfo? [1] https://stackoverflow.com/questions/48754619/what-are-cmake-build-type-debug-release-relwithdebinfo-and-minsizerel -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251524 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251524%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
