https://bugzilla.redhat.com/show_bug.cgi?id=2255846 --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- > There are source code files of catch2 library in test/3rdparty, which are used in compiling tests that will > not be in binary RPM. So I think it will not be marked as bundled. Good catch, I'll replace this with the system one as it's easy enough > I have one question that needs to deal with. The upstream also provides the CMake build system file, which can use %cmake_install can install the package files to corresponding install location. I suggest use cmake, since the library is header-only, it will make no difference. afaict the only meaningful feature that meson provides and cmake does not is setting the MAGIC_ENUM_ENABLE_HASH define if one builds with -Dhash=true. Given that it's a header-only library, this is irrelevant -- I agree, using cmake seems to be the better option here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2255846 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255846%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
