[Bug 2247275] Review Request: python-flexparser - Parsing made fun … using typing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2247275

Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |quantum.analyst@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #12 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> ---
(In reply to Ben Beasley from comment #8)
> (In reply to Elliott Sales de Andrade from comment #7)
> > You should probably check and remove the comment in %files.
> 
> The note isn’t a TODO for myself, but a note for the benefit of other
> reviewers and readers, a habit I got into as an early adopter of
> pyproject-rpm-macros. I suppose that the license file handling is now
> sufficiently well-known that I can stop adding this comment.
>
> It’s probably not worth uploading a new spec and SRPM to remove the comment,
> but I’m happy to remove it on import.
>

You can now pass -l to %pyproject_save_files.


Everything else looks good to me.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2247275

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247275%23c12
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux