Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libdc1394 - IEEE 1394 based Digital Camera control library https://bugzilla.redhat.com/show_bug.cgi?id=239043 ------- Additional Comments From kwizart@xxxxxxxxx 2008-01-16 07:21 EST ------- Few notes (not a full review - I let this to Rathann). You are missing to BuildRequires: libtool, doxygen And I don't see where libX11 is used (not in libs nor in example binaries) It could be dropped probably. Maybe the autotools regeneration could be dropped, which will also drop the libtool needs. I would think it is valuable to build the docs into a separate package to avoid multilibs problems. It is Also required to split the binaries from the libs for the same purpose. (there is a need to check if some binary is mandatory for the software to work or if they are only examples). See http://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks (specially you could use make install DESTDIR=%{buildroot} INSTALL="%{__install} -p" ) * tested against pre gcc 4.3.0 - it works - good * about the juju include - as a userland application, we shouldn't search for headers from within the kernel-devel. But in this case we want to link from the internal version: dc1394/juju (which is done as a falback as kernel-devel isn't BR). It might be possible to have it from the kernel-headers when available. * Not a complete review anyway, I let Rathann do it. (will be AFK next week). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review