https://bugzilla.redhat.com/show_bug.cgi?id=2255982 --- Comment #12 from loise@xxxxxxx <loise@xxxxxxx> --- (In reply to marcdeop from comment #11) > Please remove this: > > ``` > %global revision %(echo %{version} | cut -d. -f3) > %if %{revision} >= 50 > %global stable unstable > %else > %global stable stable > %endif > ``` > > Alternatively you can do > > ``` > %global stable %stable_kf6 Maybe you missed the discussion on IRC yesterday and the days before. I very much appreciate making things simpler and cleaner, but in this case, it breaks generating the URL if kf6-rpm-macros are not installed and availabe on a system (which is regularly the case using copr, where I noticed the stable_kf6 macro doesn't work when it should provide the URL for the download for building the srpm. I'm happy for more discussions finding out what is best to do and then change that, and if everyone insists on changing something proven functional into something that is not functional under all circumstances, then so be it, I will do that, but from a technical viewpoint it is not doing anymore what it should technically do :) Mind, I'm not discussing just because of it, I'm trying to find an equivalent solution that still guarantees the URL can be resolved (I made an example where it doesn't yesterday for those on IRC, I can re-do that again for you if you like) > ``` > > Are we sure `-DQT_MAJOR_VERSION=6` is needed? Isn't that the default? Yes, CMakeLists.txt does use that and defaults to 5, so if you want a version using Qt6 you have to set this (see the according parallel rpm for Qt5/KF5, https://src.fedoraproject.org/rpms/kf5-libkdcraw where I took the spec file and modified it) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2255982 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255982%23c12 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
