https://bugzilla.redhat.com/show_bug.cgi?id=2255935 --- Comment #5 from Lyes Saadi <fedora@xxxxxxx> --- > - Is the patch still needed, since python-filetype has to be updated anyway? It is not, it was only present here for the sake of building it to test it, but even smoke tests ended up failing under filetype 1.1.0. I will remove them. > - Note the summary-too-long rpmlint error below. Can you make Summary more > succinct? Perhaps "A single Python API for multiple image libraries"? Good idea! Wasn't sure if that error was important, but a shorter summary is a good idea anyway. > - Please consider not building for i686, by adding this to the spec file: > > ExcludeArch: %{ix86} > > See https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval This is a noarch package, I do not really see the purpose in adding this, since it doesn't add build time, and it would be installable on i686 anyway? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255935 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255935%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
