https://bugzilla.redhat.com/show_bug.cgi?id=2255886 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- > %define __cmake_in_source_build 1 I think you can drop this and simplify this spec since we do out-of-source builds properly and automatically now. > # No binary at all, so disable debuginfo package > %global debug_package %{nil} This can be dropped since you have "BuildArch: noarch" already. > mkdir build > cd build > %cmake3 -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO .. This should be replaced with "%cmake -DUSE_QT5=TRUE -DPULL_TRANSLATIONS=NO". > cd build > make install/fast DESTDIR=%{buildroot} This should be replaced with "%cmake_install" -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255886 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255886%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
