https://bugzilla.redhat.com/show_bug.cgi?id=2252778 --- Comment #3 from Andrej Manduch <amanduch@xxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/burlak/python3-gql/fedora-39-x86_64/06814416-python-gql/python-gql.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/burlak/python3-gql/fedora-39-x86_64/06814416-python-gql/python-gql-3.4.1-1.fc39.src.rpm Hi Orion, Thanks for the review. I'm posting a new spec file and srpm where I tried to fix the issues you mentioned. > * You are using an old python template will old macro (%python_provide). Please check out the updated guidelines - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/. This should also resolve the unowned directories. ALso note that removal of .egg-info is no longer needed. I changed %py3_build to %pyproject_wheel and %py3_install to %pyproject_install, with this I also included build dependendies for python3-pip and python3-whel. > * It seems to bundle gql-checker in the source, but not in the packaged files, so I think we are okay there. But worth looking into unbundling it. > * Remove the rpmautospec cruft from the .spec file and build your src.rpm with rpmbuild -bs *.spec to avoid the rpmautospec stuff I think. Definitely don't want to import that. I removed %autorelease and %autochangelog > * Use %{_bindir} done > * Do you really need the latest beta? Not really, I felt it's most appropriate as it's the latest version on pip, and changes seem insignificant, but I don't care. I changed it to last non-beta release. > * Add %check with running tests This night be a bit tricky. As far as I know, all (or at least most) tests in gql library need an internet connection, and I believe it's not available in the fedora build process. Do you have any suggestions on how can I fix it? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2252778 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252778%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
