https://bugzilla.redhat.com/show_bug.cgi?id=2255561 Davide Cavalca <davide@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(davide@xxxxxxxxxx | |me) | --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Thanks for the review! > * E: spelling-error ('bugzilla', '%description -l en_US bugzilla -> Bugzilla, buzzkill') I fixed this upstream and will fix in the package description > * E: spelling-error ('onboarded', '%description -l en_US onboarded -> on boarded, on-boarded, onboard ed') This is a real word, the spellchecker is wrong: https://www.merriam-webster.com/dictionary/onboarding > * W: no-manual-page-for-binary fedora-sig-onboard I'll write one upstream eventually and get it included, but not right now. > * Add %license LICENSE to %files This isn't actually needed when using the pyproject macros (as this package does), because they already pull in and tag the license file properly: $ rpm -qlp fedora-sig-onboard-0.1.0-1.fc40.noarch.rpm [...] /usr/lib/python3.12/site-packages/fedora_sig_onboard-0.1.0.dist-info/LICENSE [...] See https://src.fedoraproject.org/rpms/pyproject-rpm-macros for more details (search for %license in the README). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255561%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
