https://bugzilla.redhat.com/show_bug.cgi?id=2255574 --- Comment #2 from Tom Rix <trix@xxxxxxxxxx> --- The build fails because I assume it needs rocrand 6.0 Do we want to add version logic to the rocm packages in BuildRequire ? This is a for all rocm packages question. Some minor things %global toolchain clang could be %global toolchain rocm %bcond_with check run some tests could be %bcond_with test create the -test subpackage I prefer the -test subpackage because I can build on one beefy machine and copy the rpm's to a test machines that have different hw. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255574 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255574%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue