Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ndisc6 - IPv6 diagnostic tools https://bugzilla.redhat.com/show_bug.cgi?id=424841 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-16 01:05 EST ------- One important question before I assign this to myself: Is this your first package for Fedora? You haven't indicated that you need sponsorship, but I don't see your name on the list of packagers. What's your FAS ID? Since I have this package open, I might as well run through my checklist. Looking at the source, the License: tag should "GPLv2 or GPLv3". They permit only those versions, not "any later version". The latest version now seems to be 0.9.5. Did you want to update? You can save yourself a little pain by using the %find_lang macro; at the end of %install, add %find_lang %{name} and then change your files section to start with: %files -f %{name}.lang and remove the two %lang(* lines from your %files list. This will automatically find all of the .po and related files and include just the right directories and %lang tags for you. * source files match upstream: 13f238cc03e43dd05020755b3a5ec57d3cfa1eecfba71dc00157d26351afe718 ndisc6-0.9.3.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. X license field matches the actual license. * license is open source-compatible. * license text included in package. ? latest version is 0.9.5. * BuildRequires are proper (none) * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: ndisc6 = 0.9.3-2.fc9 = /bin/sh /usr/bin/perl perl(Getopt::Std) perl(strict) * %check is not present; no test suite upstream. No ipv6 here so I can't test this. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review