https://bugzilla.redhat.com/show_bug.cgi?id=2255182 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Reviewed against local / COPR builds of this package's dependencies. === The project contains a bundled copy of the "plasma-wayland-protocols" project (appears to be version 1.10.0). This needs to be declared (i.e. "Provides: bundled(plasma-wayland-protocols) = 1.10.0" or something similar) in the -devel subpackage. Additionally, those protocol definitions are covered by various licenses (BSD-3-Clause, LGPL-2.1-or-later, MIT, MIT-CMU, as far as I can tell). License files for these are already included in the package, but they must be added to the license tag of the package as well. I don't think the license metadata in Cargo.toml needs to be changed, since only MIT-licensed code that is generated *from* these protocol definitions will be linked into dependent applications, but not the protocol definitions *themselves*. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2255182 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255182%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue