Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: iputils https://bugzilla.redhat.com/show_bug.cgi?id=225909 ------- Additional Comments From panemade@xxxxxxxxx 2008-01-15 22:54 EST ------- 1)You need to add following as you are calling service from %preun Requires(preun): /sbin/service 2) Please add macros. MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. Still I can see SPEC have following lines which does not follow macros install -cp rdisc ${RPM_BUILD_ROOT}/sbin/ install -cp ping6 ${RPM_BUILD_ROOT}/bin/ install -cp tracepath ${RPM_BUILD_ROOT}/bin/ install -cp tracepath6 ${RPM_BUILD_ROOT}/bin/ Also, No macro uses in %files. See http://fedoraproject.org/wiki/Packaging/RPMMacros -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review