[Bug 2248911] Review Request: neon2sse - Open standard for machine learning interoperability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2248911



--- Comment #2 from Tom Rix <trix@xxxxxxxxxx> ---
> %global with_snapshot 1 

Clean this up, there should be only 1 way to get the source, this is a messy
upstream project, make which git commit you fetch as easy as possible.

> Summary:        Open standard for machine learning interoperability 

This summary does not match the project.
Find a way to simplify

The platform independent header allowing to compile any C/C++ code containing
ARM NEON intrinsic functions for x86 target systems using SIMD up to SSE4
intrinsic functions

> %global desc %{expand: \

I am not a fan of expanding and, the description should be close to the readme
text

The NEON_2_SSE.h file is intended ...

Since it likely does not make sense to install this header on a non x86, likely
you need some logic like

BuildArch: noarch
ExclusiveArch: x86_64

It would be good to have a %check
Can you do something like

https://src.fedoraproject.org/rpms/xbyak_aarch64/blob/rawhide/f/xbyak_aarch64.spec#_88

> Requires:       %{name}%{?_isa} = %{version}-%{release}

There is only the -devel package, without the normal package, this causes a
failure to install. Remove this line.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2248911

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248911%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux