https://bugzilla.redhat.com/show_bug.cgi?id=2251510 --- Comment #16 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- (In reply to ycollet from comment #14) > I fixed the man installation via a patch. Thanks! Would you please submit the patch upstream and link the PR in the spec file? Let me know if I can help with that. - Upstream repo: https://github.com/brummer10/jalv_select - Relevant guideline: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_all_patches_should_have_an_upstream_bug_link_or_comment > I fixed the version using epoch + formatting of the release field. Do you plan to build on EPEL7, too? Otherwise packages should use the tilde/caret versions for pre- and post-release snapshots: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_handling_non_sorting_versions_with_tilde_dot_and_caret Thankfully, it will sort well after the change, 1:1.3.0^20221019git29ea666-1 sorts higher than 1:1.3.0-6.20221019git29ea666 for RPM. > I fixed the jalv-gtkmm problem. Thanks! One thing I missed originally is that the changelog should describe changes relevant to users (e.g. version updates, patches applied), i.e. if it’s irrelevant, just skip the entry. And it’s suggested to let the "Release:" field and package changelog be automatically generated (from git commits and their log entries): https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs I’m biased here, as I was involved in implementing this feature 😉, but it can save you some work. However, it doesn’t work in COPR (as there are no meaningful log entries with the commits) – maybe let’s change this when importing the package into distgit. With the changes mentioned above, it would look like: ... Epoch: 1 Version: 1.3.0^%{commitdate}git%{shortcommit0} Release: %autorelease ... %changelog %autochangelog ... As here, I would put the "Epoch:" field above "Version:", just so these fields are in order of significance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2251510 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251510%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
