Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Net-NBName - Net::NBName perl module https://bugzilla.redhat.com/show_bug.cgi?id=428777 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-15 19:06 EST ------- This one build OK; rpmlint says: perl-Net-NBName.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Net-NBName-0.26/README perl-Net-NBName.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Net-NBName-0.26/Changes perl-Net-NBName.noarch: E: wrong-script-end-of-line-encoding /usr/bin/nodescan.pl perl-Net-NBName.noarch: E: wrong-script-end-of-line-encoding /usr/bin/nodestat.pl perl-Net-NBName.noarch: E: wrong-script-end-of-line-encoding /usr/bin/namequery.pl All of these can be fixed with a quick pass through sed; see http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues perl-Net-NBName.noarch: E: script-without-shebang /usr/bin/nodescan.pl perl-Net-NBName.noarch: E: script-without-shebang /usr/bin/nodestat.pl perl-Net-NBName.noarch: E: script-without-shebang /usr/bin/namequery.pl These scripts are executable, but the first line of each doesn't contain the '#!' line that would enable the kernel to know how to run them. As a result these scripts do nothing except spew shell errors. You will need to add #!/usr/bin/perl to each. Checklist: * source files match upstream: 947cf41234f88779086f851748a86b04bf6f851f0d84b8950c8e3fbdbf20cd2e Net-NBName-0.26.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X rpmlint has valid complaints. * final provides and requires are sane: perl(Net::NBName) = 0.26 perl(Net::NBName::NameQuery) = 0.26 perl(Net::NBName::NameQuery::RR) = 0.26 perl(Net::NBName::NodeStatus) = 0.26 perl(Net::NBName::NodeStatus::RR) = 0.26 perl(Net::NBName::Request) perl-Net-NBName = 0.26-1.fc9 = perl(:MODULE_COMPAT_5.8.8) perl(Net::NBName::NameQuery) perl(Net::NBName::NameQuery::RR) perl(Net::NBName::NodeStatus) perl(Net::NBName::NodeStatus::RR) perl(Socket) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=2, Tests=23, 0 wallclock secs ( 0.08 cusr + 0.01 csys = 0.09 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review