[Bug 428776] Review Request: perl-SNMP-Info - SNMP::Info perl module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-SNMP-Info - SNMP::Info perl module


https://bugzilla.redhat.com/show_bug.cgi?id=428776





------- Additional Comments From tibbs@xxxxxxxxxxx  2008-01-15 18:48 EST -------
OK, this one fails to build due to a missing dependency on perl(Test::More).
Adding that gets a bit further, then:

t/prereq....
Net-SNMP not found.  Net-SNMP installs the perl modules
[...]
Plus there's nice insult to "Redhat" (whatever that is) in the output.

Adding another build dependency on perl(Net::SNMP) still results in the same
error.  On a lark I added a build dependency on net-snmp and that didn't work.
However, a dependency on perl(SNMP) did.

Please be kind to your reviewer and try make sure that your packages build
properly.  I know that's hard to do because you can't do scratch builds in
koji until you're sponsored, but you can still install mock to do proper build
testing on a minimal system.

After getting a clean build, rpmlint has the following to say:
  perl-SNMP-Info.noarch: W: file-not-utf8 
   /usr/share/doc/perl-SNMP-Info-1.04/README
  perl-SNMP-Info.noarch: W: file-not-utf8
   /usr/share/man/man3/SNMP::Info.3pm.gz
These can be fixed by calling iconv; see the
http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues page for
an example.

Finally, the test suite says:

Make sure you download and install the MIBS needed for SNMP::Info.
See Man page or perldoc for SNMP::Info.

and I wonder if there's anything extra that needs to be added.

Checklist:
* source files match upstream:
   1e23225ee98205b36dc58fa45548a0b99ea795003d8cc002c27506e072bf3592  
   SNMP-Info-1.04.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
X BuildRequires missing perl(Test::More) perl(SNMP).
* %clean is present.
* package builds in mock (rawhide, x86_64) (after adding missing build deps)
* package installs properly
X rpmlint has valid complaints.
* final provides and requires are sane:
   perl(SNMP::Info) = 1.04
   perl(SNMP::Info::Airespace) = 1.04
   perl(SNMP::Info::Bridge) = 1.04
   perl(SNMP::Info::CDP) = 1.04
   perl(SNMP::Info::CiscoImage) = 1.04
   perl(SNMP::Info::CiscoQOS) = 1.04
   perl(SNMP::Info::CiscoRTT) = 1.04
   perl(SNMP::Info::CiscoStack) = 1.04
   perl(SNMP::Info::CiscoStats) = 1.04
   perl(SNMP::Info::CiscoVTP) = 1.04
   perl(SNMP::Info::Entity) = 1.04
   perl(SNMP::Info::EtherLike) = 1.04
   perl(SNMP::Info::FDP) = 1.04
   perl(SNMP::Info::Layer1) = 1.04
   perl(SNMP::Info::Layer1::Allied) = 1.04
   perl(SNMP::Info::Layer1::Asante) = 1.04
   perl(SNMP::Info::Layer1::Bayhub) = 1.04
   perl(SNMP::Info::Layer1::S3000) = 1.04
   perl(SNMP::Info::Layer2) = 1.04
   perl(SNMP::Info::Layer2::Aironet) = 1.04
   perl(SNMP::Info::Layer2::Allied) = 1.04
   perl(SNMP::Info::Layer2::Aruba) = 1.04
   perl(SNMP::Info::Layer2::Bay) = 1.04
   perl(SNMP::Info::Layer2::Baystack) = 1.04
   perl(SNMP::Info::Layer2::C1900) = 1.04
   perl(SNMP::Info::Layer2::C2900) = 1.04
   perl(SNMP::Info::Layer2::Catalyst) = 1.04
   perl(SNMP::Info::Layer2::Centillion) = 1.04
   perl(SNMP::Info::Layer2::Cisco) = 1.04
   perl(SNMP::Info::Layer2::Foundry) = 1.04
   perl(SNMP::Info::Layer2::HP) = 1.04
   perl(SNMP::Info::Layer2::N2270) = 1.04
   perl(SNMP::Info::Layer2::NAP222x) = 1.04
   perl(SNMP::Info::Layer2::Orinoco) = 1.04
   perl(SNMP::Info::Layer2::ZyXEL_DSLAM) = 1.04
   perl(SNMP::Info::Layer3) = 1.04
   perl(SNMP::Info::Layer3::Aironet) = 1.04
   perl(SNMP::Info::Layer3::AlteonAD) = 1.04
   perl(SNMP::Info::Layer3::BayRS) = 1.04
   perl(SNMP::Info::Layer3::C3550) = 1.04
   perl(SNMP::Info::Layer3::C4000) = 1.04
   perl(SNMP::Info::Layer3::C6500) = 1.04
   perl(SNMP::Info::Layer3::Cisco) = 1.04
   perl(SNMP::Info::Layer3::Contivity) = 1.04
   perl(SNMP::Info::Layer3::Extreme) = 1.04
   perl(SNMP::Info::Layer3::Foundry) = 1.04
   perl(SNMP::Info::Layer3::Juniper) = 1.04
   perl(SNMP::Info::Layer3::N1600) = 1.04
   perl(SNMP::Info::Layer3::Passport) = 1.04
   perl(SNMP::Info::MAU) = 1.04
   perl(SNMP::Info::NortelStack) = 1.04
   perl(SNMP::Info::RapidCity) = 1.04
   perl(SNMP::Info::SONMP) = 1.04
   perl-SNMP-Info = 1.04-1.fc9
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(Exporter)
   perl(Math::BigInt)
   perl(SNMP)
   perl(SNMP::Info)
   perl(SNMP::Info::Airespace)
   perl(SNMP::Info::Bridge)
   perl(SNMP::Info::CDP)
   perl(SNMP::Info::CiscoImage)
   perl(SNMP::Info::CiscoQOS)
   perl(SNMP::Info::CiscoRTT)
   perl(SNMP::Info::CiscoStack)
   perl(SNMP::Info::CiscoStats)
   perl(SNMP::Info::CiscoVTP)
   perl(SNMP::Info::Entity)
   perl(SNMP::Info::EtherLike)
   perl(SNMP::Info::FDP)
   perl(SNMP::Info::Layer1)
   perl(SNMP::Info::Layer2)
   perl(SNMP::Info::Layer3)
   perl(SNMP::Info::MAU)
   perl(SNMP::Info::NortelStack)
   perl(SNMP::Info::RapidCity)
   perl(SNMP::Info::SONMP)
   perl(strict)
   perl(vars)

 %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=3,  0 wallclock secs ( 0.02 cusr +  0.01 csys =  0.03 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]