[Bug 2253031] Review Request: python-torchdata - A PyTorch module for data loading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2253031



--- Comment #6 from Tim Flink <tflink@xxxxxxxxxx> ---
(In reply to Tom Rix from comment #3)
> Spec URL: https://trix.fedorapeople.org/python-torchdata.spec
> SRPM URL: https://trix.fedorapeople.org/python-torchdata-0.7.0-2.fc40.src.rpm
> 
> The listed twice is a warning, not an error, is caused by the %dir
> declarations.
> 
> I have commented on why no check, it depends on expecttest
> https://github.com/ezyang/expecttest
> That looks like it is a low value to package.
> 
> However if you will take the review of expecttest, I will add it.

Looking at expecttest, I agree that it's probably not worth packaging. The
concept is interesting but according to libraries.io [1], it's only used by 2
packages on pypi.

For the listed twice thing, I get that it's a warning but is there a reason for
it to be listed twice? I would have thought that the sitelib dir would be found
by echo+find+sed or by listing the sitelib dir and egg file manually. Why do it
twice?

[1] https://libraries.io/pypi/expecttest


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2253031

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253031%23c6
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux