https://bugzilla.redhat.com/show_bug.cgi?id=2253723 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Requires: crypto-auditing-agent This is not attached to any package, since there is no binary package named "rust-crypto-auditing-client" being built. Move this under the "crypto-auditing-client" subpackage for it to have the intended effect. > License: GPL-3.0-or-later AND (MIT OR Apache-2.0) AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND MIT AND (MIT OR Apache-2.0) AND (Unlicense OR MIT) There are three occurrences of "(MIT OR Apache-2.0)" here, please drop all but one of them (where "(MIT OR Apache-2.0)" and "(Apache-2.0 OR MIT)" are equivalent). > %config(noreplace) %{_sysconfdir}/crypto-auditing/client.conf This leaves the directory at "%{_sysconfdir}/crypto-auditing/" unowned, add this to fix it: %dir %{_sysconfdir}/crypto-auditing/ Other than those three minor issues, looks good to me. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2253723 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253723%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
