[Bug 2254460] Review Request: vlc - VLC media player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2254460

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Yaakov Selkowitz from comment #10)
> (In reply to Neal Gompa from comment #8)
> > Then let's not use autochangelog either until we actually can do that. But
> > this can be fixed on import.
> 
> I'm not aware of anything saying that one cannot be used without the other,
> but I discovered %autorelease -b 3 accomplishes what is needed, so I've
> switched to that locally.
> 
> (In reply to Neal Gompa from comment #9)
> > Please move this to the %build stage so that "fedpkg prep" will work
> > properly.
> 
> By definition, fedpkg prep relies on the system to run any commands, so you
> would need bison, prep, gettext-devel, and libtool.  While there may be some
> debate on where autoreconf belongs, it is quite common to be in %prep rather
> than %build, and I see nothing in the packaging guidelines to the contrary.

*technically* the FPC has banned running thinkgs like %configure in %prep:
https://pagure.io/packaging-committee/issue/1159

Not sure why this ticket was closed without actually making any changes to the
guidelines.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2254460

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254460%23c11
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux