https://bugzilla.redhat.com/show_bug.cgi?id=2249646 --- Comment #7 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- Some quick notes - Fedora is migrating to SPDX license identifiers https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_3 ❯ license-fedora2spdx "GPLv3" GPL-3.0-only - per the debian/copyright, and given this actually has both COPYING and COPYING.LESSER, you actually want License: GPL-3.0-or-later AND LGPL-3.0-or-later and document the license breakdown in a comment above (we don't have as structured a way to declare this as Debian unfortunately) $ license-fedora2spdx "GPLv3+" GPL-3.0-or-later $ license-fedora2spdx "LGPLv3+" LGPL-3.0-or-later e.g. # GPL-3.0-or-later: * # LGPL-3.0-or-later: pam_*.c *.h License: GPL-3.0-or-later AND LGPL-3.0-or-later - I'd recommend using %autosetup over %setup -q -- in case you need to apply patches later on, it is easier (e.g. %autosetup -p1 will apply every listed patches with -p1) - rm -rf $RPM_BUILD_ROOT is no longer needed, see e.g. https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_GNU_Hello/ (I think the page documenting the cleanup is no longer up, it's been a while) - packager preference: I like having one BuildRequires per line, that makes the deltas easier to parse if you add dependency. Not blocking the review though - %doc is empty, do you mean to do %doc README.md ? - you also need %license COPYING %license COPYING.LESSER (they can be combined on the same line if you want) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249646%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
