https://bugzilla.redhat.com/show_bug.cgi?id=2246560 --- Comment #10 from Kate Hsuan <hpa@xxxxxxxxxx> --- Hi, Thank you for updating. Two minor issues need to be improved. 1. Thanks Neal for pointing out this. The three commands could be moved from %prep section to %build section. 2. "Requires: dbus-tools" could be removed. I briefly looked into the code. Only the test script runs dbus-tools to send DBus messages but the test script was not included in the package. dbus-tools is a set of commands for DBus and includes the following files. ... /usr/bin/dbus-monitor /usr/bin/dbus-send /usr/bin/dbus-update-activation-environment /usr/bin/dbus-uuidgen ... I'll also update the review checklist here for the next version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246560 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246560%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
