https://bugzilla.redhat.com/show_bug.cgi?id=2247559 --- Comment #11 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Comments: a) IT is typical to put the README.md in the main package rather than in the docs package. b) The docs package should be a noarch package and should be called doc not docs c) The doc package should also have %license LICENSE as it does not require the main package. d) Rather than using %exclude %{_libdir}/cmake/gemmlowp/gemmlowp-config-noconfig.cmake %exclude %{_libdir}/cmake/gemmlowp/gemmlowp-config.cmake Please add %dir %{_libdir}/cmake/gemmlowp %{_libdir}/cmake/gemmlowp/gemmlowp-config-noconfig.cmake %{_libdir}/cmake/gemmlowp/gemmlowp-config.cmake to the devel package as these files are useful for builds using CMake which have gemmlowp as a dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2247559 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247559%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
