https://bugzilla.redhat.com/show_bug.cgi?id=2253357 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review! (In reply to Benson Muite from comment #2) > Comment: > a) May consider running benchmark program as a test of functionality. > Perhaps modifying > https://github.com/orlp/pdqsort/blob/master/bench/bench.cpp#L127 > to use only small sizes. Can be done on import. Okay, that's a good idea. > b) Please apply spelling correction suggestions in the description. It looks like every one of those suggestions is wrong. :-) The algorithms really are named quicksort and heapsort, and the previous project really is named introsort. > c) Approved. Thank you! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2253357 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253357%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
