https://bugzilla.redhat.com/show_bug.cgi?id=2253490 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Spec review: > # trim changelog included in binary rpms > %global _changelog_trimtime %(date +%s -d "1 year ago") This can be dropped. We have a global setting in redhat-rpm-config now. > %global mysql mysql > %if 0%{?rhel} > 6 > # el7 mariadb pkgs don't have compat Provides: mysql (apparently?) > %global mysql mariadb > %endif This can be dropped and we can just depend on mysql directly. > Conflicts: akonadi < 1.13.0-100 > > # translations moved here > Conflicts: kde-l10n < 17.03 > > # when kf5-akonadi was split, -socialutils was dropped > Obsoletes: kf5-akonadi-socialutils < 16.07 This can be dropped. > Obsoletes: kf5-akonadi-devel < 16.03 > # when kf5-akonadi was split, -socialutils was dropped > Obsoletes: kf5-akonadi-socialutils-devel < 16.07 This can be dropped. > # at least dbus-1/interfaces conflict, maybe more -- rex > Conflicts: akonadi-devel We also need a "Conflicts: kf5-akonadi-server-devel" here. > # upgrade path > Obsoletes: akonadi < 1.7.90-2 > Obsoletes: akonadi-mysql < 15.08.0 This can be dropped. > %if "%{?mysql}" != "mariadb" && 0%{?fedora} > 20 > Recommends: mariadb-server > %endif This can be dropped. We'll depend on "mysql-server". -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2253490 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253490%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue