https://bugzilla.redhat.com/show_bug.cgi?id=2252491 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The package is exactly as produced by rust2rpm, except: - quick-junit-fix-metadata.diff removes the nextest-workspace-hack dependency, which is reasonable to do downstream-only - License files missing from the crate (but corresponding to its metadata, and taken from the same git repository) are added - Tests are disabled due to a missing dev dependency. More comments on the latter two changes appear in the Issues section. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/quick- junit-0.3.4/CHANGELOG.md See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is due to rust2rpm listing the entire %{crate_instdir}/ and then separately listing some of its contents as %doc. The duplication appears to be harmless; if it is a problem, then it should be fixed in rust2rpm. - The license files are correctly added, but we should help upstream fix this in future releases. I filed an issue, Crates are missing license files https://github.com/nextest-rs/nextest/issues/1149 and a PR, Fix missing license files in published crates https://github.com/nextest-rs/nextest/pull/1150 Please reference these in a spec-file comment. - Running the the tests is not mandatory, but it would be nice if they can be enabled at some point. - The current version is 0.3.5, but the submitted package is for 0.3.4. Please update to the latest version if there is not a specific reason not to. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License". 5 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2252491-rust-quick- junit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. I took care of this; please reference the issue and PR in a spec-file comment. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- quick-junit-devel , rust-quick-junit+default-devel [?]: Package functions as described. [!]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. Ok; this is necessary and is done correctly. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. Tests are disabled due to missing dependencies. This is not ideal, but does not block the review. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-quick-junit-devel-0.3.4-1.fc40.noarch.rpm rust-quick-junit+default-devel-0.3.4-1.fc40.noarch.rpm rust-quick-junit-0.3.4-1.fc40.src.rpm ============================================== rpmlint session starts ============================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptvqsh1kj')] checks: 31, packages: 3 rust-quick-junit+default-devel.noarch: W: no-documentation =============== 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s =============== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 rust-quick-junit-devel.noarch: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized') rust-quick-junit-devel.noarch: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized') rust-quick-junit+default-devel.noarch: E: spelling-error ('serializer', 'Summary(en_US) serializer -> serialize, serializes, serialized') rust-quick-junit+default-devel.noarch: E: spelling-error ('serializer', '%description -l en_US serializer -> serialize, serializes, serialized') rust-quick-junit+default-devel.noarch: W: no-documentation 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 8 filtered, 4 badness; has taken 0.2 s Source checksums ---------------- https://github.com/nextest-rs/nextest/raw/quick-junit-0.3.4/LICENSE-MIT : CHECKSUM(SHA256) this package : 23f18e03dc49df91622fe2a76176497404e46ced8a715d9d2b67a7446571cca3 CHECKSUM(SHA256) upstream package : 23f18e03dc49df91622fe2a76176497404e46ced8a715d9d2b67a7446571cca3 https://github.com/nextest-rs/nextest/raw/quick-junit-0.3.4/LICENSE-APACHE : CHECKSUM(SHA256) this package : a60eea817514531668d7e00765731449fe14d059d3249e0bc93b36de45f759f2 CHECKSUM(SHA256) upstream package : a60eea817514531668d7e00765731449fe14d059d3249e0bc93b36de45f759f2 https://crates.io/api/v1/crates/quick-junit/0.3.4/download#/quick-junit-0.3.4.crate : CHECKSUM(SHA256) this package : ce24fb76d27e9a9a5ae0ef71e1735f252a2f6334207abcfd4ad9a1868b58c271 CHECKSUM(SHA256) upstream package : ce24fb76d27e9a9a5ae0ef71e1735f252a2f6334207abcfd4ad9a1868b58c271 Requires -------- rust-quick-junit-devel (rpmlib, GLIBC filtered): (crate(chrono/default) >= 0.4.31 with crate(chrono/default) < 0.5.0~) (crate(indexmap/default) >= 2.0.2 with crate(indexmap/default) < 3.0.0~) (crate(quick-xml/default) >= 0.30.0 with crate(quick-xml/default) < 0.31.0~) (crate(strip-ansi-escapes/default) >= 0.2.0 with crate(strip-ansi-escapes/default) < 0.3.0~) (crate(thiserror/default) >= 1.0.50 with crate(thiserror/default) < 2.0.0~) (crate(uuid/default) >= 1.5.0 with crate(uuid/default) < 2.0.0~) cargo rust rust-quick-junit+default-devel (rpmlib, GLIBC filtered): cargo crate(quick-junit) Provides -------- rust-quick-junit-devel: crate(quick-junit) rust-quick-junit-devel rust-quick-junit+default-devel: crate(quick-junit/default) rust-quick-junit+default-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2252491 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, Ocaml, PHP, Python, fonts, C/C++, Haskell, R, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2252491 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252491%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
