https://bugzilla.redhat.com/show_bug.cgi?id=2251086 --- Comment #15 from Tim Flink <tflink@xxxxxxxxxx> --- (In reply to Tom Rix from comment #14) > (In reply to Tim Flink from comment #12) > > (In reply to Tim Flink from comment #11) > > > > > > The explicit list of AMDGPU_TARGETS is missing some, you can see in the > > > > cmake output that gfx94x is checked. > > > > If we need a full list, I think it would be useful to add that to > > > > rocm-rpm-macros package macros.rocm file. > > > > > > I'm unclear on why we want to do this. I know that there are some rocm > > > packages where the full library is too large when all of the gpu targets are > > > enabled but rocfft isn't one of those. I get disabling some older targets to > > > make the library size reasonable but why disable older card families if we > > > don't have to? > > > > NVM, I managed to misread what you wrote. Ignore that comment, please. > > By using an explicit list, you are missing some gpu's. > I am asking why these gpus are missing. Unfortunately, I started packaging rocfft so long ago, I don't remember. It doesn't match the default from cmake so I must have copied it from somewhere. I'll remove it as I can't think of a reason to limit the gpu families for rocfft, it doesn't have size issues with expanding that list. Thanks for catching it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251086%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
