https://bugzilla.redhat.com/show_bug.cgi?id=2250534 --- Comment #2 from Petr Menšík <pemensik@xxxxxxxxxx> --- Found just two minor issues: [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libirc- devel %package -n libirc-devel is not necessary, just use %package devel %description devel %files %license COPYING %doc README.md %{_libdir}/libirc.so.0 %{_libdir}/libirc.so.%{version} %files devel %{_includedir}/irc %{_datadir}/pkgconfig/libirc.pc %{_libdir}/libirc.so I would also include %url in Source0: Source0: %{url}/archive/refs/tags/%{version}.tar.gz#/%{name}-%{version}.tar.gz But since none of that are blocking the review, I am passing it right away. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2250534 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202250534%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
