[Bug 2252615] Review Request: python-menuinst - Cross platform menu item installation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2252615



--- Comment #4 from Orion Poplawski <orion@xxxxxxxx> ---
(In reply to Jerry James from comment #3)
> Issues:
> =======
> - The python3-apipkg package is bundled; see menuinst/_vendor/apipkg.  Can it
>   be unbundled?  If not, then:
>     - its license (MIT) should be added to the License field
>     - its license file (menuinst/_vendor/apipkg/LICENSE) should be installed
>     - the main package should add "Provides: bundled(python3-apipkg) = 3.0.1"

apipkg is only needed on Windows so I've simply removed it.

> - menuinst/platforms/win_utils/knownfolders.py carries an MIT license, and is
>   included in the binary RPM, so MIT must be added to the License field in
> any
>   case

Likewise not needed, so removed.
> 
> - Please consider using %autorelease and %autochangelog.  (This is a
> suggestion
>   only, not a requirement.)

Done :)

Spec URL: https://orion.fedorapeople.org/python-menuinst.spec
SRPM URL: https://orion.fedorapeople.org/python-menuinst-2.0.0-1.fc40.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2252615

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252615%23c4
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux