https://bugzilla.redhat.com/show_bug.cgi?id=2252353 --- Comment #8 from Orion Poplawski <orion@xxxxxxxx> --- (In reply to Jerry James from comment #7) > ===== Issues ===== > - The python3-libmambapy package is missing > Requires: %{name}%{?_isa} = %{version}-%{release} Good catch. Added. > - Note the rpmlint non-conffile-in-etc warnings. Should those files be marked > %config(noreplace)? Hmm, this is a bit grey. I would argue these are not config files - they are critical for setting up micromamba to work properly. As precedent, the following /etc/profile.d files on my system are not marked config: /etc/profile.d/colorxzgrep.csh /etc/profile.d/colorxzgrep.sh /etc/profile.d/colorzgrep.csh /etc/profile.d/colorzgrep.sh /etc/profile.d/conda.csh /etc/profile.d/conda.sh /etc/profile.d/flatpak.sh /etc/profile.d/gawk.csh /etc/profile.d/gawk.sh /etc/profile.d/lang.csh /etc/profile.d/lang.sh /etc/profile.d/less.csh /etc/profile.d/less.sh /etc/profile.d/micromamba.csh /etc/profile.d/micromamba.sh /etc/profile.d/modules.csh /etc/profile.d/modules.sh /etc/profile.d/toolbox.sh /etc/profile.d/vte.csh /etc/profile.d/vte.sh /etc/profile.d/which2.csh /etc/profile.d/which2.sh > > - Note the rpmlint no-manual-page-for-binary warning. Is there a way to > generate a man page, say with help2man? I've asked upstream for a way to build one for micromamba specifically with the sphinx sources. For now I've used help2man. > - I would encourage you to use %autorelease and %autochangelog, like the other > packages I have reviewed for you today. (This is not a MUST, though.) I still spend most of my time on EL8 where rpmautospec is still a bit of a pain. Spec URL: https://orion.fedorapeople.org/libmamba.spec SRPM URL: https://orion.fedorapeople.org/libmamba-1.5.3-2.fc40.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2252353 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252353%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
