[Bug 2213078] Review Request: goldendict-ng - The Next Generation GoldenDict

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2213078

Beck Liu <shattuckite@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shattuckite@xxxxxxxxxxx



--- Comment #21 from Beck Liu <shattuckite@xxxxxxxxxxx> ---
+ package name is OK
+ license is acceptable for Fedora
+ builds and installs OK
+ the dependencies look correct
+ no scriptlets needed or present

And all the comments from another reviewer has been resolved.

> goldendict-ng.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/goldendict-ng (RUNPATH: $ORIGIN:$ORIGIN/../lib64)

the rpath issue should be solved by `chrpath --delete
%{buildroot}%{_bindir}/goldendict-ng`



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[ ]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[ ]: License file installed when any subpackage combination is installed.
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 11257 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 5294080 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.


Rpmlint
-------
Checking: goldendict-ng-23.11.30-1.20230805gitb6420c8.fc40.x86_64.rpm
          goldendict-ng-debuginfo-23.11.30-1.20230805gitb6420c8.fc40.x86_64.rpm
         
goldendict-ng-debugsource-23.11.30-1.20230805gitb6420c8.fc40.x86_64.rpm
          goldendict-ng-23.11.30-1.20230805gitb6420c8.fc40.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpknpnwov5')]
checks: 31, packages: 4

goldendict-ng.spec:67: W: unversioned-explicit-provides
bundled(qtsingleapplication)
goldendict-ng.spec:68: W: unversioned-explicit-provides bundled(js-darkreader)
goldendict-ng.spec:69: W: unversioned-explicit-provides
bundled(js-iframe-resizer)
goldendict-ng.spec:70: W: unversioned-explicit-provides bundled(js-jquery)
goldendict-ng.x86_64: W: no-manual-page-for-binary goldendict-ng
goldendict-ng.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/goldendict-ng
(RUNPATH: $ORIGIN:$ORIGIN/../lib64)
 4 packages and 0 specfiles checked; 1 errors, 5 warnings, 1 badness; has taken
1.2 s 




Rpmlint (debuginfo)
-------------------
Checking: goldendict-ng-debuginfo-23.11.30-1.20230805gitb6420c8.fc40.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpd50ki5vm')]
checks: 31, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken
0.5 s 





Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "goldendict-ng".
(none): E: there is no installed rpm "goldendict-ng-debugsource".
(none): E: there is no installed rpm "goldendict-ng-debuginfo".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts
============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0
badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/xiaoyifang/goldendict-ng/archive/b6420c87f7c6aa23a9aad2cf44800568862d0107/goldendict-ng-b6420c87f7c6aa23a9aad2cf44800568862d0107.tar.gz
:
  CHECKSUM(SHA256) this package     :
a8a367050a2639b7de2e9bf22ce887eda83b0b779c543df6b3ce1bdd7d3c10e2
  CHECKSUM(SHA256) upstream package :
a8a367050a2639b7de2e9bf22ce887eda83b0b779c543df6b3ce1bdd7d3c10e2


Requires
--------
goldendict-ng (rpmlib, GLIBC filtered):
    libQt6Core.so.6()(64bit)
    libQt6Core.so.6(Qt_6)(64bit)
    libQt6Core.so.6(Qt_6.6)(64bit)
    libQt6Core5Compat.so.6()(64bit)
    libQt6Core5Compat.so.6(Qt_6)(64bit)
    libQt6Gui.so.6()(64bit)
    libQt6Gui.so.6(Qt_6)(64bit)
    libQt6Multimedia.so.6()(64bit)
    libQt6Multimedia.so.6(Qt_6)(64bit)
    libQt6Network.so.6()(64bit)
    libQt6Network.so.6(Qt_6)(64bit)
    libQt6PrintSupport.so.6()(64bit)
    libQt6PrintSupport.so.6(Qt_6)(64bit)
    libQt6TextToSpeech.so.6()(64bit)
    libQt6TextToSpeech.so.6(Qt_6)(64bit)
    libQt6WebChannel.so.6()(64bit)
    libQt6WebChannel.so.6(Qt_6)(64bit)
    libQt6WebEngineCore.so.6()(64bit)
    libQt6WebEngineCore.so.6(Qt_6)(64bit)
    libQt6WebEngineWidgets.so.6()(64bit)
    libQt6WebEngineWidgets.so.6(Qt_6)(64bit)
    libQt6Widgets.so.6()(64bit)
    libQt6Widgets.so.6(Qt_6)(64bit)
    libQt6Xml.so.6()(64bit)
    libQt6Xml.so.6(Qt_6)(64bit)
    libX11.so.6()(64bit)
    libXtst.so.6()(64bit)
    libavcodec.so.60()(64bit)
    libavcodec.so.60(LIBAVCODEC_60)(64bit)
    libavformat.so.60()(64bit)
    libavformat.so.60(LIBAVFORMAT_60)(64bit)
    libavutil.so.58()(64bit)
    libavutil.so.58(LIBAVUTIL_58)(64bit)
    libbz2.so.1()(64bit)
    libc.so.6()(64bit)
    libeb.so.16()(64bit)
    libfmt.so.10()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhunspell-1.7.so.0()(64bit)
    liblzma.so.5()(64bit)
    liblzma.so.5(XZ_5.0)(64bit)
    liblzo2.so.2()(64bit)
    libm.so.6()(64bit)
    libopencc.so.1.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libswresample.so.4()(64bit)
    libswresample.so.4(LIBSWRESAMPLE_4)(64bit)
    libtomlplusplus.so.3()(64bit)
    libvorbisfile.so.3()(64bit)
    libxapian.so.30()(64bit)
    libz.so.1()(64bit)
    libz.so.1(ZLIB_1.2.0)(64bit)
    libz.so.1(ZLIB_1.2.0.2)(64bit)
    libz.so.1(ZLIB_1.2.2.3)(64bit)
    libzim.so.8()(64bit)
    rtld(GNU_HASH)

goldendict-ng-debuginfo (rpmlib, GLIBC filtered):

goldendict-ng-debugsource (rpmlib, GLIBC filtered):



Provides
--------
goldendict-ng:
    application()
    application(io.github.xiaoyifang.goldendict_ng.desktop)
    bundled(js-darkreader)
    bundled(js-iframe-resizer)
    bundled(js-jquery)
    bundled(qtsingleapplication)
    goldendict-ng
    goldendict-ng(x86-64)
    metainfo()
    metainfo(io.github.xiaoyifang.goldendict_ng.metainfo.xml)
    mimehandler(x-scheme-handler/dict)
    mimehandler(x-scheme-handler/goldendict)

goldendict-ng-debuginfo:
    debuginfo(build-id)
    goldendict-ng-debuginfo
    goldendict-ng-debuginfo(x86-64)

goldendict-ng-debugsource:
    goldendict-ng-debugsource
    goldendict-ng-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name
goldendict-ng --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Python, R, SugarActivity, Haskell, fonts, Ocaml, PHP, Perl,
Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2213078

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202213078%23c21
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux