https://bugzilla.redhat.com/show_bug.cgi?id=2252512 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license_family.cpython-312.opt-1.pyc is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text This is because the main package does not contain a license file, and does not have a dependency on the python3 package, which does contain a license file. Is it correct that neither package depends on the other? If so, the license file should be added to the main package with %license. - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/jamesjer/2252512-conda-build/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ The diff shows one minor change to a file named .git_archival.txt. I guess upstream must have moved the 3.27.0 tag after you downloaded it. Not a big deal. In any case, version 3.28.0 has been released. - Regarding the License field, conda_build/version.py carries a BSD-2-Clause notice at the top. - See the non-executable-script warning from rpmlint below. Should that file be in the package? If so, should it be executable? - See the no-manual-page-for-binary rpmlint warnings below. Is there any way to generate man pages for those binaries, say with help2man? - See the description-line-too-long rpmlint warnings below. Can you reformat %description so that lines do not wrap on systems limited to 80 columns? ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License", "BSD 2-Clause License", "*No copyright* BSD 3-Clause License", "BSD 3-Clause License and/or GNU Lesser General Public License and/or MIT License", "BSD 3-Clause License and/or MIT License", "*No copyright* MIT License", "*No copyright* zlib License", "*No copyright* GNU General Public License, Version 2", "Apache License 2.0", "*No copyright* GNU General Public License", "*No copyright* University of Illinois/NCSA Open Source License", "*No copyright* Apache License 2.0". 872 files have unknown license. The BSD-2-Clause license should be mentioned in License. The other licenses are for files that are not included in the binary RPMs, mostly test files. [!]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 190945 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [-]: Package contains the mandatory BuildRequires and Requires:. Python: [x]: Binary eggs must be removed in %prep [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-conda-build Neither package requires the other. Is this correct? [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/jamesjer/2252512-conda-build/srpm- unpacked/conda-build.spec See: (this test has no URL) I don't know what this means. The source RPM has the conda-build name. The spec file is conda-build.spec. The Name field in the spec file contains "conda-build". What is fedora-review complaining about here? [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: conda-build-3.27.0-1.fc40.noarch.rpm python3-conda-build-3.27.0-1.fc40.noarch.rpm conda-build-3.27.0-1.fc40.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp7ywpftww')] checks: 31, packages: 3 conda-build.src: W: strange-permission conda-build-3.27.0.tar.gz 660 conda-build.src: W: strange-permission conda-build.spec 660 python3-conda-build.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/conda_build/launcher_sources/build.sh 644 /usr/bin/env bash conda-build.noarch: W: no-manual-page-for-binary conda-build conda-build.noarch: W: no-manual-page-for-binary conda-convert conda-build.noarch: W: no-manual-page-for-binary conda-debug conda-build.noarch: W: no-manual-page-for-binary conda-develop conda-build.noarch: W: no-manual-page-for-binary conda-index conda-build.noarch: W: no-manual-page-for-binary conda-inspect conda-build.noarch: W: no-manual-page-for-binary conda-metapackage conda-build.noarch: W: no-manual-page-for-binary conda-render conda-build.noarch: W: no-manual-page-for-binary conda-skeleton conda-build.noarch: W: no-documentation python3-conda-build.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/conda_build/skeletons/__init__.py /usr/lib/python3.12/site-packages/conda_build/cli/__init__.py:/usr/lib/python3.12/site-packages/conda_build/os_utils/__init__.py conda-build.noarch: E: description-line-too-long (replacing username with the user name of the person whose channel you want to add). conda-build.src: E: description-line-too-long (replacing username with the user name of the person whose channel you want to add). python3-conda-build.noarch: E: description-line-too-long (replacing username with the user name of the person whose channel you want to add). ================ 3 packages and 0 specfiles checked; 4 errors, 13 warnings, 4 badness; has taken 0.6 s ================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-conda-build.noarch: E: spelling-error ('dir', '%description -l en_US dir -> deer, jr, rid') conda-build.noarch: E: spelling-error ('dir', '%description -l en_US dir -> deer, jr, rid') python3-conda-build.noarch: W: python-missing-require beautifulsoup4 python3-conda-build.noarch: W: python-missing-require chardet python3-conda-build.noarch: W: python-missing-require conda-index python3-conda-build.noarch: W: python-missing-require conda-package-handling python3-conda-build.noarch: W: python-missing-require conda python3-conda-build.noarch: W: python-missing-require filelock python3-conda-build.noarch: W: python-missing-require jinja2 python3-conda-build.noarch: W: python-missing-require libarchive-c python3-conda-build.noarch: W: python-missing-require packaging python3-conda-build.noarch: W: python-missing-require pkginfo python3-conda-build.noarch: W: python-missing-require psutil python3-conda-build.noarch: W: python-missing-require pytz python3-conda-build.noarch: W: python-missing-require pyyaml python3-conda-build.noarch: W: python-missing-require requests python3-conda-build.noarch: W: python-missing-require six python3-conda-build.noarch: W: python-missing-require tqdm python3-conda-build.noarch: E: non-executable-script /usr/lib/python3.12/site-packages/conda_build/launcher_sources/build.sh 644 /usr/bin/env bash conda-build.noarch: W: no-manual-page-for-binary conda-build conda-build.noarch: W: no-manual-page-for-binary conda-convert conda-build.noarch: W: no-manual-page-for-binary conda-debug conda-build.noarch: W: no-manual-page-for-binary conda-develop conda-build.noarch: W: no-manual-page-for-binary conda-index conda-build.noarch: W: no-manual-page-for-binary conda-inspect conda-build.noarch: W: no-manual-page-for-binary conda-metapackage conda-build.noarch: W: no-manual-page-for-binary conda-render conda-build.noarch: W: no-manual-page-for-binary conda-skeleton conda-build.noarch: W: no-documentation python3-conda-build.noarch: W: files-duplicate /usr/lib/python3.12/site-packages/conda_build/skeletons/__init__.py /usr/lib/python3.12/site-packages/conda_build/cli/__init__.py:/usr/lib/python3.12/site-packages/conda_build/os_utils/__init__.py python3-conda-build.noarch: E: description-line-too-long (replacing username with the user name of the person whose channel you want to add). conda-build.noarch: E: description-line-too-long (replacing username with the user name of the person whose channel you want to add). 2 packages and 0 specfiles checked; 5 errors, 27 warnings, 8 filtered, 5 badness; has taken 0.2 s Source checksums ---------------- https://github.com/conda/conda-build/archive/3.27.0/conda-build-3.27.0.tar.gz : CHECKSUM(SHA256) this package : 2b59898a3d385d786e539e7b9eb012b2b4e50e757e5c4c840d68988990a5d9cc CHECKSUM(SHA256) upstream package : 013592ee86c443961799adf96840434bad9851fe789b75e213d881819f42c5d9 diff -r also reports differences Requires -------- conda-build (rpmlib, GLIBC filtered): /usr/bin/python3 python3-conda-build (rpmlib, GLIBC filtered): /usr/bin/perl python(abi) python3.12dist(beautifulsoup4) python3.12dist(chardet) python3.12dist(conda) python3.12dist(conda-index) python3.12dist(conda-package-handling) python3.12dist(filelock) python3.12dist(jinja2) python3.12dist(libarchive-c) python3.12dist(packaging) python3.12dist(pkginfo) python3.12dist(psutil) python3.12dist(pytz) python3.12dist(pyyaml) python3.12dist(requests) python3.12dist(six) python3.12dist(tqdm) Provides -------- conda-build: conda-build python3-conda-build: python-conda-build python3-conda-build python3.12-conda-build python3.12dist(conda-build) python3dist(conda-build) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2252512 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Perl, Shell-api, Python Disabled plugins: Ocaml, SugarActivity, Haskell, fonts, Ruby, R, PHP, Java, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2252512 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252512%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
