https://bugzilla.redhat.com/show_bug.cgi?id=2252608 Orion Poplawski <orion@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-12-03 15:36:50 --- Comment #4 from Orion Poplawski <orion@xxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > + package name is OK > + license is acceptable for Fedora (Apache-2.0 OR MIT) > + license is in SPDX > + license is specified correctly > + R/P/BR look OK (%generate_buildrequires is used) > + %check is present > + package builds and installs OK > > No rpmautospec? Why, oh, why? I spend most of my time on EL8 and rpmautospec is a pain there. Also, I'm old and set in my ways. :) > rpmlint says: > python3-archspec.noarch: W: no-manual-page-for-binary archspec > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.git > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.github > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.github > > Please remove .git and .github. Thanks, removed. > This is a standard template-based python package, everything looks normal. > Package is APPROVED. Thanks for the review. Checked in and built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2252608 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252608%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
