https://bugzilla.redhat.com/show_bug.cgi?id=2246560 Kate Hsuan <hpa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #5 from Kate Hsuan <hpa@xxxxxxxxxx> --- Thank you for updating. Overall this work looked good but some minor things need to be improved. 1. In the %description section, “it puts the system into Low Power Mode by activate the power efficient CPUs and disable the rest, and restore the system from Low Power Mode by activating all CPUs.” should be “it puts the system into Low Power Mode by activating the power efficient CPUs and disabling the rest, and restoring the system from Low Power Mode by activating all CPUs.” 2. Add a newline after %global %global daemon_name intel_lpmd. 3. In the %file section, the dbus configuration files should be placed in %{_datadir}/dbus-1. (/usr/share/dbus-1) %config(noreplace) %{_sysconfdir}/dbus-1/system.d/org.freedesktop.%{daemon_name}.conf could be %{_datadir}/dbus-1/system.d/org.freedesktop.%{daemon_name}.conf 4. The DBus introspection file should also be placed to /usr/share/dbus-1/interfaces so the %install and the %file sections need to be revised and shown as follows. The %install section could be (Move and copy the files to the corresponding place) %install %make_install mv %{buildroot}/%{_sysconfdir}/dbus-1/system.d %{buildroot}/%{_datadir}/dbus-1 install -p -D -m 0644 src/intel_lpmd_dbus_interface.xml %{buildroot}/%{_datadir}/dbus-1/interfaces/org.freedesktop.intel_lpmd.xml The file section could be simplified like this … %dir %{_sysconfdir}/%{daemon_name} %config(noreplace) %{_sysconfdir}/%{daemon_name}/%{daemon_name}_config.xml %{_datadir}/dbus-1/* %{_unitdir}/%{daemon_name}.service %{_mandir}/man5/%{daemon_name}_config.xml.5* … Please prepare a new version addressing the things listed above. I will perform a comprehensive test for the next revision. Thank you :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246560 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246560%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
